Release only if changes exist #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
changed the title
fleupold
approved these changes
Feb 2, 2024
MartinquaXD
reviewed
Feb 2, 2024
.github/workflows/release.yml
Outdated
| - name: Check for changes since last tag | ||
| id: check_changes | ||
| run: | | ||
| LATEST_TAG=$(git tag --sort=-authordate --merged=main | head --lines 1) |
There was a problem hiding this comment.
I believe this needs to sort by commit date in case we merge a commit that was authored before some other commit but only merged afterwards.
Probably an edge case that might never arise but this seems safer regardless.
There was a problem hiding this comment.
Tested on pull_request. Switched to committerdate sorting.
squadgazzz
force-pushed
the
check-changes-before-release
branch
from
037864f
to
6359024
Compare
squadgazzz
force-pushed
the
check-changes-before-release
branch
from
bf59071
to
bf3345e
Compare
MartinquaXD
approved these changes
Feb 7, 2024
fleupold
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the weekly release if there are no changes.