Merge pull request #7 from gnosisguild/fix-deprecated-api

fix: no longer use rmdirSync API, which is deprecated on latest node v21
gnosisguild · Aug 29, 2024 · 4fd895f · 4fd895f
2 parents 0cf16d6 + 9be0980
commit 4fd895f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.changeset/perfect-dryers-rest.md b/.changeset/perfect-dryers-rest.md
@@ -0,0 +1,5 @@
+---
+"@gnosis-guild/eth-sdk": patch
+---
+
+fix: no longer use rmdirSync API, which is deprecated on latest node v21
diff --git a/packages/eth-sdk/src/peripherals/fs.ts b/packages/eth-sdk/src/peripherals/fs.ts
@@ -24,6 +24,6 @@ export const realFs: Fs = {
   readDir: (path) => fsExtra.readdir(path),
   glob: promisify(glob),
   rmDir: (path) => {
-    fs.rmdirSync(path, { recursive: true })
+    fs.rmSync(path, { recursive: true })
   },
 }
diff --git a/packages/eth-sdk/test/filesystemMock.ts b/packages/eth-sdk/test/filesystemMock.ts
@@ -41,9 +41,6 @@ export function mockFilesystem(files: Record<FilePath, FileContents | DirectoryM
       return Object.keys(files).filter(minimatch.filter(pattern, options))
     },
     rmDir(path) {
-      if (files[normalize(path)] !== DirectoryMarker) {
-        throw new Error('Not a directory')
-      }
       delete files[normalize(path)]
     },
   }