Merge pull request #356 from gnosisguild/fix-direct-exec

fix: error when executing as safe owner without mod
gnosisguild · Dec 16, 2024 · 492f7be · 492f7be
2 parents e274976 + ed0e004
commit 492f7be
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/extension/.vscode/settings.json b/extension/.vscode/settings.json
@@ -7,5 +7,9 @@
   "editor.codeActionsOnSave": {
     "source.fixAll.eslint": "explicit"
   },
-  "typescript.tsdk": "node_modules/typescript/lib"
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "search.exclude":{
+    "node_modules": true,
+    "public/build": true
+  }
 }
diff --git a/extension/package.json b/extension/package.json
@@ -22,7 +22,7 @@
     "check-types": "tsc --noEmit",
     "check-cycles": "madge -c --warning --ts-config tsconfig.json ./src/panel/app.tsx ./src/background/index.ts",
     "lint": "eslint . --max-warnings=0",
-    "fix": "pnpm fix:format && pnpm fix:lint",
+    "fix": "pnpm fix:lint",
     "fix:lint": "pnpm check:lint --fix"
   },
   "devDependencies": {

diff --git a/extension/src/panel/pages/$activeRouteId/transactions/Submit.tsx b/extension/src/panel/pages/$activeRouteId/transactions/Submit.tsx
@@ -87,6 +87,7 @@ export const Submit = () => {
         message: (
           <a
             href={`${EXPLORER_URL[chainId]}/tx/${txHash}`}
+            className="inline-flex items-center gap-1"
             target="_blank"
             rel="noopener noreferrer"
           >
@@ -106,7 +107,8 @@ export const Submit = () => {
         title: 'Transaction batch has been proposed for execution',
         message: (
           <a
-            href={`//app.safe.global/transactions/tx?safe=${avatar}&id=multisig_${avatarAddress}_${safeTxHash}`}
+            href={`https://app.safe.global/transactions/tx?safe=${avatar}&id=multisig_${avatarAddress}_${safeTxHash}`}
+            className="inline-flex items-center gap-1"
             target="_blank"
             rel="noopener noreferrer"
           >
@@ -126,6 +128,7 @@ export const Submit = () => {
         message: (
           <a
             href={`${EXPLORER_URL[chainId]}/tx/${txHash}`}
+            className="inline-flex items-center gap-1"
             target="_blank"
             rel="noopener noreferrer"
           >