Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct execution through Safe owner is not working #352

Closed
jfschwarz opened this issue Dec 13, 2024 · 3 comments · Fixed by #356
Closed

Direct execution through Safe owner is not working #352

jfschwarz opened this issue Dec 13, 2024 · 3 comments · Fixed by #356
Assignees
Labels
bug Something isn't working

Comments

@jfschwarz
Copy link
Collaborator

Describe the bug
If I using a connection without a mod, where the Pilot Account is an owner of the Piloted Safe, it fails on submit:

To Reproduce
Steps to reproduce the behavior:

  1. Create a route with a Safe you own
  2. Connect your wallet, set it to the Safe owner address
  3. Launch route
  4. Record a call and submit 💥
image

Expected behavior
It should let me sign the Safe transaction (typed message). The transaction should afterwards appear in the respective Safe app for the other owners to confirm it.

@jfschwarz jfschwarz added the bug Something isn't working label Dec 13, 2024
@jfschwarz
Copy link
Collaborator Author

root cause seems to be in ser-kit: gnosisguild/ser-kit#12

@jfschwarz
Copy link
Collaborator Author

After upgrading ser-kit, we're getting a step closer, but it still fails:

image

@frontendphil it's still this darn import issue 🚑

@frontendphil
Copy link
Member

It would be just awesome if this PR, which's been sitting there for a while now, would "just" be merged safe-global/safe-core-sdk#1049 AFAICT it works. I don't know what the hold-up is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants