chore: In mobile/Makefile, use ts_check after node_modules #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
added a commit
to jefft0/gnonative
that referenced
this pull request
Oct 4, 2024
This is the same fix as gnoverse/dsocial#134 Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
added a commit
to jefft0/gnonative
that referenced
this pull request
Oct 8, 2024
…ch target This is the same fix as PR gnoverse/dsocial#134 Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
added a commit
to jefft0/gnonative
that referenced
this pull request
Oct 8, 2024
…ch target This is the same fix as PR gnoverse/dsocial#134 Signed-off-by: Jeff Thompson <jeff@thefirst.org>
jefft0
added a commit
to gnolang/gnonative
that referenced
this pull request
Oct 10, 2024
Similar to PR gnoverse/dsocial#130, we update gnoboard to use the new Gno Native Kit API which removes `selectAccount` and requires passing the account address to `setPassword`, etc. This PR has five commits: 1. The app needs to keep track of the active account, so add `GnoboardProvider`. 2. Instead of calling Gno Native Kit `selectAccount`, call `GnoboardProvider` `setAccount` to remember the active account. 3. `setPassword` needs the account address, so in `ReenterPassword` add param `accountAddress`. 4. In wallet/home: Pass in the account instead of calling `getActiveAccount`. Use the account address to call `queryAccount`. 5. As in a [similar dsocial PR](gnoverse/dsocial#134), fix the Makefile to call ts_check after node_modules. With this PR, all known apps have been updated to remove `selectAcount` and to pass the account address to the methods of Gno Native Kit, which can be updated to remove deprecated functions and to make the address not optional. --------- Signed-off-by: Jeff Thompson <jeff@thefirst.org>
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mobile/Makefile, we want to run ts_check for most build targets. Most build targets use node_modules, so we put ts_check as a dependency of the node_modules target. But this makes ts_check run before
npm install. This doesn't work because ts_check needsnpm installto run first in order to install tsc.This pull request removes ts_check for the dependency of node_modules and adds it explicitly to the dependencies of build targets after node_modules.