Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v1 #1

Merged
merged 4 commits into from
Sep 22, 2023
Merged

feat: v1 #1

merged 4 commits into from
Sep 22, 2023

Conversation

moul
Copy link
Contributor

@moul moul commented Sep 10, 2023

Import work from gnolang/gno#1092.

I'm pondering a few things about our setup:

  1. Where's the best spot for the package: misc/, gnovm/, new top-level namespace, or its own repo?
  2. Should this be a standalone command or a part of gno?
  3. Right now, the command processes .gnoffee files and gives us output. You can see it on screen or save it using -w. But here's the twist: it currently blends the new bits with all the .gnoffee scripts, creating a full .go file. Another idea is to just pinpoint and add what's missing, resulting in a gnoffee.gen.go file. I'm weighing up both approaches and would appreciate your insights.

Any feedback or even a chat about it would be great. cc @gnolang/tech-staff @gnolang/core-contributors

Suggestion for reviewers: checkout the txtar tests: https://github.com/gnolang/gno/pull/1092/files#diff-a9299fce0ae91a6a0eb6e0bfc51ab83a51116d452703e4c82f473f1e933dff4f

Addresses gnolang/hackerspace#22
Addresses gnolang/gno#1075
Depends on gnolang/gno#1093 (tests fail on go1.19)

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Sep 10, 2023
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul mentioned this pull request Sep 10, 2023
7 tasks
@moul
Copy link
Contributor Author

moul commented Sep 22, 2023

Merging the initial PoC.

@moul moul merged commit 1026182 into main Sep 22, 2023
4 checks passed
@moul moul deleted the dev/moul/v1 branch September 22, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant