Remove ORC kernels that use sqrtf #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clayton Smith <argilo@gmail.com>
marcusmueller
approved these changes
Oct 19, 2023
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
Remove ORC kernels that use sqrtf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #622
(as well as gqrx-sdr/gqrx#570 and gqrx-sdr/gqrx#1191).
The
sqrtfORC instruction is dangerous, because on at least one platform (ARM) it produces sqrt(0) = NaN.@jdemel suggested in #640 that we remove affected kernels completely, so I've done that here. This may potentially reduce performance on platforms other than x86 & ARM, but it's probably worth it to not have incorrect output on ARM.
There are a couple other unused kernels that also have the
sqrtfinstruction, but they will be removed in #638.