Fix aligned loads and stores in unaligned kernels #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures are due to #646. |
marcusmueller
approved these changes
Oct 19, 2023
Signed-off-by: Clayton Smith <argilo@gmail.com>
argilo
force-pushed
the
fix-unaligned-loads
branch
from
91b6922 to
152ce7d
Compare
|
I missed an unaligned load in Test runs at various vector lengths now pass in all kernels. |
argilo
changed the title
marcusmueller
approved these changes
Oct 20, 2023
jdemel
approved these changes
Oct 22, 2023
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
Fix aligned loads and stores in unaligned kernels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various unaligned kernels (
volk_32f_accumulator_s32f_u_sse,volk_32f_s32f_s32f_mod_range_32f_u_sse2,volk_32fc_32f_dot_prod_32fc_u_avx2_fma) load input data using aligned loads, so they fail when given unaligned input buffers. Here I've fixed that by switching them to unaligned loads.