volk_32fc_x2_divide_32fc: add documentation about numerical accuracy #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniestevez
force-pushed
the
divide-aarch64
branch
from
df88d03 to
76f13d4
Compare
argilo
approved these changes
Nov 6, 2023
daniestevez
force-pushed
the
divide-aarch64
branch
from
76f13d4 to
e831b50
Compare
|
Force-pushed to fix clang format. Force-pushed again. Hopefully now it's correct. |
This adds some documentation to the complex divide kernel about the potential pitfall in some architectures of obtaining inf or nan with a small denominator (even if the numerator is zero) due to reduced range because of -fcx-limited-range and -freciprocal-math. This closes gnuradio#608. Signed-off-by: Daniel Estévez <daniel@destevez.net>
daniestevez
force-pushed
the
divide-aarch64
branch
from
e831b50 to
c364110
Compare
|
The test failure is unrelated; it's due to #663. |
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
volk_32fc_x2_divide_32fc: add documentation about numerical accuracy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some documentation to the complex divide kernel about the potential pitfall in some architectures of obtaining inf or nan with a small denominator (even if the numerator is zero) due to reduced range because of -fcx-limited-range and -freciprocal-math.
This closes #608.