Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual overhaul #2

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Visual overhaul #2

wants to merge 3 commits into from

Conversation

gnusenpai
Copy link
Owner

Adds colored finger chart and other visual changes

TODO: Make finger chart angle mod/DH compatible

#KeyY, #KeyH, #KeyN, #KeyU, #KeyJ, #KeyM {
background-color: #8080ca;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking, so you want a certain colour for the proper fingering right, and then when active for that level, it would change colour?

If we created classes like finger-01 (through to 10) and assigned them in the layoutDivs file, then we could colour them according to .finger-01 and .finger-01.active right?

Especially if you just want it to be darker, and then when active become light, you could actually just do

.finger-01 {
    background-color: somecolour;
    color: black;
    opacity: 0.5;
}

.active {
    color: white;
    opacity: 1;
}

right?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is essentially the goal, yes. That system should also make it easy to change at runtime for layouts that require different fingering like DH.

On a related note, I'd also like to be able to highlight/brighten the keys that are currently being learned (which is currently working now, albeit with a not-so-clean implementation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants