adding support for sampling config for nr

go-coldbrew · Sep 10, 2022 · dcfb3cb · dcfb3cb
1 parent 1e960c7
commit dcfb3cb
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/config/README.md b/config/README.md
@@ -13,7 +13,7 @@ import "github.com/go-coldbrew/core/config"
 - [type Config](<#type-config>)
 
 
-## type [Config](<https://github.com/go-coldbrew/core/blob/main/config/config.go#L7-L77>)
+## type [Config](<https://github.com/go-coldbrew/core/blob/main/config/config.go#L7-L79>)
 
 ```go
 type Config struct {
@@ -45,6 +45,8 @@ type Config struct {
     NewRelicDistributedTracing bool `envconfig:"NEW_RELIC_DISTRIBUTED_TRACING" default:"true"`
     // Enable new relic opentelemetry
     NewRelicOpentelemetry bool `envconfig:"NEW_RELIC_OPENTELEMETRY" default:"true"`
+    // Sampling ratio for NR opentelemetry
+    NewRelicOpentelemetrySample float64 `envconfig:"NEW_RELIC_OPENTELEMETRY_SAMPLE" default:"0.2"`
     // DSN for reporting errors to sentry
     SentryDSN string `envconfig:"SENTRY_DSN" default:""`
     // Name of this release

diff --git a/config/config.go b/config/config.go
@@ -33,6 +33,8 @@ type Config struct {
 	NewRelicDistributedTracing bool `envconfig:"NEW_RELIC_DISTRIBUTED_TRACING" default:"true"`
 	// Enable new relic opentelemetry
 	NewRelicOpentelemetry bool `envconfig:"NEW_RELIC_OPENTELEMETRY" default:"true"`
+	// Sampling ratio for NR opentelemetry
+	NewRelicOpentelemetrySample float64 `envconfig:"NEW_RELIC_OPENTELEMETRY_SAMPLE" default:"0.2"`
 	// DSN for reporting errors to sentry
 	SentryDSN string `envconfig:"SENTRY_DSN" default:""`
 	// Name of this release

diff --git a/core.go b/core.go
@@ -76,7 +76,7 @@ func (c *cb) processConfig() {
 		grpc_prometheus.EnableHandlingTimeHistogram()
 	}
 	if c.config.NewRelicOpentelemetry {
-		setupNROpenTelemetry(c.config.AppName, c.config.NewRelicLicenseKey, c.config.ReleaseName)
+		setupNROpenTelemetry(c.config.AppName, c.config.NewRelicLicenseKey, c.config.ReleaseName, c.config.NewRelicOpentelemetrySample)
 	}
 }
 

diff --git a/initializers.go b/initializers.go
@@ -104,7 +104,7 @@ func setupJaeger(serviceName string) io.Closer {
 	return closer
 }
 
-func setupNROpenTelemetry(serviceName, license, version string) {
+func setupNROpenTelemetry(serviceName, license, version string, ratio float64) {
 	if serviceName == "" || license == "" {
 		log.Info(context.Background(), "msg", "not initializing NR opentelemetry tracing")
 		return
@@ -145,7 +145,7 @@ func setupNROpenTelemetry(serviceName, license, version string) {
 	}
 
 	tracerProvider := sdktrace.NewTracerProvider(
-		sdktrace.WithSampler(sdktrace.ParentBased(sdktrace.TraceIDRatioBased(0.2))), // sample 20%
+		sdktrace.WithSampler(sdktrace.ParentBased(sdktrace.TraceIDRatioBased(ratio))), // sample 20%
 		sdktrace.WithBatcher(otlpExporter),
 		sdktrace.WithResource(r),
 	)