e2e tests: add e2e tests binary to gitignore #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teqwve
commented
Feb 7, 2024
| carbon-clickhouse | ||
|
|
||
| /carbon-clickhouse | ||
| /e2e-test |
There was a problem hiding this comment.
I added / in the beginning so that files in cmd/e2e-tests won't be ignored. And made the same for carbon-clickhouse for sake of consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that e2e-test binary is committed in the repository. I believe it was added by accident so here I remove it and add to .gitignore (so it doesn't appear as changed if somebody runs e2e tests on their machines).
And thanks for merging other two PRs :)