Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(im): change api name to make it consistent #66

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

crispgm
Copy link
Contributor

@crispgm crispgm commented Dec 27, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (543cfa8) 79.66% compared to head (c8b2f42) 79.66%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   79.66%   79.66%           
=======================================
  Files          29       29           
  Lines         890      890           
=======================================
  Hits          709      709           
  Misses        128      128           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crispgm
Copy link
Contributor Author

crispgm commented Dec 27, 2023

@sjatsh sorry to bother. I made changes to the names from RectionMessage/DeleteRectionMessage to AddRection/DeleteRection to make it consistent in naming. So there will be a minor breaking change. You may have to update later.

@crispgm crispgm merged commit 3b0dcee into main Dec 27, 2023
1 check passed
@crispgm crispgm deleted the consistency-of-reactions branch December 27, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants