place endpoint are added #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
почему мы храним это в папке auth, если это никак с авторизацией не связано |
timurIsaevIY
force-pushed
the
Task_getPlace
branch
from
8e9e0a9 to
3f8090f
Compare
vr009
reviewed
Sep 29, 2024
vr009
reviewed
Sep 29, 2024
vr009
reviewed
Sep 29, 2024
internal/pkg/middleware/cors.go
Outdated
| w.Header().Set("Access-Control-Allow-Methods", "POST,PUT,DELETE,GET") | ||
| w.Header().Set("Access-Control-Allow-Headers", "Content-Type") | ||
| w.Header().Set("Access-Control-Allow-Credentials", "true") | ||
| w.Header().Set("Access-Control-Allow-Origin", r.Header.Get("Origin")) |
There was a problem hiding this comment.
Вот это плохо. Суть CORS в том, что бэкенд отдает этим заголовком информацию браузеру, с каких сайтов (Origin) пропускать запросы на бэк. А мы таким образом будем позволять браузеру отправлять запросы на бэк с любого сайта. В общем смотри инфу про cors (например тут).
vr009
reviewed
Sep 29, 2024
vr009
reviewed
Sep 29, 2024
vr009
approved these changes
Sep 29, 2024
vr009
pushed a commit
that referenced
this pull request
Sep 30, 2024
* place endpoint are added * errors fixed * json * nginx are added * errors fixed * docker changed * errors fixed * errors fixed * errors fixed * errors fixed * errors fixed
vr009
pushed a commit
that referenced
this pull request
Sep 30, 2024
* place endpoint are added * errors fixed * json * nginx are added * errors fixed * docker changed * errors fixed * errors fixed * errors fixed * errors fixed * errors fixed
timurIsaevIY
added a commit
that referenced
this pull request
Sep 30, 2024
* place endpoint are added * errors fixed * json * nginx are added * errors fixed * docker changed * errors fixed * errors fixed * errors fixed * errors fixed * errors fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.