tweak: use rankdir consistent naming

go-vela · Oct 31, 2023 · d109018 · d109018
1 parent 519859c
commit d109018
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 11 deletions.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -34,7 +34,9 @@ services:
   # https://go-vela.github.io/docs/administration/server/
   server:
     container_name: server
-    image: target/vela-server:latest
+    # image: target/vela-server:latest
+    build:
+      context: ../server/
     networks:
       - vela
     environment:

diff --git a/src/elm/Main.elm b/src/elm/Main.elm
@@ -979,8 +979,8 @@ update msg model =
 
         BuildGraphRotate ->
             let
-                orientation =
-                    case gm.orientation of
+                rankdir =
+                    case gm.rankdir of
                         DOT.LR ->
                             DOT.TB
 
@@ -989,7 +989,7 @@ update msg model =
 
                 ugm =
                     { gm
-                        | orientation = orientation
+                        | rankdir = rankdir
                     }
 
                 um_ =

diff --git a/src/elm/Pages/Build/Graph/DOT.elm b/src/elm/Pages/Build/Graph/DOT.elm
@@ -135,9 +135,9 @@ renderDOT model repo build buildGraph =
             else
                 ""
 
-        -- reverse the subgraphs for top-bottom orientation to consistently group services and built-ins
+        -- reverse the subgraphs for top-bottom rankdir to consistently group services and built-ins
         rotation =
-            case model.repo.build.graph.orientation of
+            case model.repo.build.graph.rankdir of
                 TB ->
                     List.reverse
 
@@ -157,7 +157,7 @@ renderDOT model repo build buildGraph =
             , serviceSubgraph
             ]
     in
-    digraph (baseGraphStyles model.repo.build.graph.orientation)
+    digraph (baseGraphStyles model.repo.build.graph.rankdir)
         (rotation subgraphs)
 
 
@@ -296,8 +296,8 @@ edgeToString edge =
 {-| baseGraphStyles : returns the base styles applied to the root graph.
 -}
 baseGraphStyles : Rankdir -> Styles
-baseGraphStyles orientation =
-    { rankdir = orientation
+baseGraphStyles rankdir =
+    { rankdir = rankdir
     , graph =
         escapeAttributes
             [ ( "bgcolor", DefaultEscape "transparent" )

diff --git a/src/elm/Pages/Build/Graph/View.elm b/src/elm/Pages/Build/Graph/View.elm
@@ -54,7 +54,7 @@ view model msgs org repo buildNumber =
                         , class "-icon"
                         , class "build-graph-action-rotate"
                         , class <|
-                            case model.repo.build.graph.orientation of
+                            case model.repo.build.graph.rankdir of
                                 DOT.TB ->
                                     "-vertical"
 

diff --git a/src/elm/Vela.elm b/src/elm/Vela.elm
@@ -1416,7 +1416,7 @@ type alias BuildGraphRenderInteropData =
 type alias BuildGraphModel =
     { buildNumber : BuildNumber
     , graph : WebData BuildGraph
-    , orientation : DOT.Rankdir
+    , rankdir : DOT.Rankdir
     , filter : String
     , focusedNode : Int
     , showServices : Bool