fixing things

go-vela · Nov 1, 2023 · eceaf12 · eceaf12
1 parent 923ae0c
commit eceaf12
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/elm/Pages/Build/View.elm b/src/elm/Pages/Build/View.elm
@@ -158,7 +158,6 @@ viewPreview msgs openMenu showMenu now zone org repo showTimestamp build =
 
         buildMenuAttributeList : List (Html.Attribute msg)
         buildMenuAttributeList =
-            -- TODO: validate what swapping the order of these did
             Util.open (List.member build.id openMenu) ++ [ id "build-actions" ]
 
         restartBuild : Html msgs
@@ -197,7 +196,7 @@ viewPreview msgs openMenu showMenu now zone org repo showTimestamp build =
                 details (buildMenuBaseClassList :: buildMenuAttributeList)
                     [ summary [ class "summary", Util.onClickPreventDefault (msgs.toggle (Just build.id) Nothing), Util.testAttribute "build-menu" ]
                         [ text "Actions"
-                        , FeatherIcons.chevronDown |> FeatherIcons.withSize 20 |> FeatherIcons.withClass "details-icon-expand" |> FeatherIcons.toHtml [ attribute "aria-label" "Start-Step-Logs" ]
+                        , FeatherIcons.chevronDown |> FeatherIcons.withSize 20 |> FeatherIcons.withClass "details-icon-expand" |> FeatherIcons.toHtml [ attribute "aria-label" "show build actions" ]
                         ]
                     , ul [ class "build-menu", attribute "aria-hidden" "true", attribute "role" "menu" ]
                         [ restartBuild
@@ -446,7 +445,7 @@ viewStepDetails model msgs rm step =
                     [ div [ class "-name" ] [ text step.name ]
                     , div [ class "-duration" ] [ text <| Util.formatRunTime model.time step.started step.finished ]
                     ]
-                , FeatherIcons.chevronDown |> FeatherIcons.withSize 20 |> FeatherIcons.withClass "details-icon-expand" |> FeatherIcons.toHtml [ attribute "aria-label" "Start-Step-Logs" ]
+                , FeatherIcons.chevronDown |> FeatherIcons.withSize 20 |> FeatherIcons.withClass "details-icon-expand" |> FeatherIcons.toHtml [ attribute "aria-label" "show build actions" ]
                 ]
             , div [ class "logs-container" ] [ viewStepLogs msgs.logsMsgs model.shift rm step ]
             ]
@@ -1061,7 +1060,7 @@ followButton followStep resourceType number following =
         , onClick <| followStep toFollow
         , attribute "aria-label" <| tooltip ++ " for " ++ resourceType ++ " " ++ number
         ]
-        [ icon |> FeatherIcons.toHtml [ attribute "role" "img", attribute "aria-label" "Start-Step-Logs" ] ]
+        [ icon |> FeatherIcons.toHtml [ attribute "role" "img", attribute "aria-label" "show build actions" ] ]
 
 
 {-| viewResourceError : checks for build error and renders message

diff --git a/src/scss/_main.scss b/src/scss/_main.scss
@@ -191,7 +191,7 @@ nav {
     color: var(--color-black);
 
     list-style-type: none;
-    background-color: var(--color-bg-darkest);
+    background-color: var(--color-bg-dark);
   }
 
   li {

diff --git a/src/scss/_themes.scss b/src/scss/_themes.scss
@@ -6,7 +6,6 @@
 // dark theme (default)
 body,
 body.theme-dark {
-  --color-bg-darkest: var(--color-coal-dark);
   --color-bg-dark: var(--color-coal-dark);
   --color-bg: var(--color-coal);
   --color-bg-light: var(--color-coal-light);
@@ -29,7 +28,6 @@ body.theme-dark {
 
 // light theme
 body.theme-light {
-  --color-bg-darkest: var(--color-gray-light);
   --color-bg-dark: var(--color-gray-light);
   --color-bg: var(--color-offwhite);
   //   --color-bg-light: var(--color-white);