Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: required changes from api build types migration #608

Closed
wants to merge 3 commits into from

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Oct 4, 2024

depends on: go-vela/server#1204

this is subject to change when pipeline and step are migrated, but until then we need it to build the worker

make build

executor/local/step.go:53:50: c.build.ToLibrary undefined (type *"github.com/go-vela/server/api/types".Build has no field or method ToLibrary)

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.51%. Comparing base (1632331) to head (36580b7).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   62.21%   57.51%   -4.70%     
==========================================
  Files         121      121              
  Lines        8214     5211    -3003     
==========================================
- Hits         5110     2997    -2113     
+ Misses       2878     1988     -890     
  Partials      226      226              
Files with missing lines Coverage Δ
executor/linux/step.go 76.08% <100.00%> (-2.00%) ⬇️
executor/local/step.go 91.78% <100.00%> (-0.47%) ⬇️

... and 98 files with indirect coverage changes

@wass3rw3rk
Copy link
Member

not needed anymore

@wass3rw3rk wass3rw3rk closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants