Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to require biometrics before revealing/sending to XL the OTP code #15

Open
Berna-L opened this issue Mar 30, 2022 · 1 comment
Open

Option to require biometrics before revealing/sending to XL the OTP code #15

Berna-L opened this issue Mar 30, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Berna-L
Copy link

Berna-L commented Mar 30, 2022

For better security, could there be an option for the auth app to require the user to authenticate themselves using the device's biometrics (fingerprint, Touch/Face ID etc.) when opened, and only after and if it's successful the app reveals the OTP code or transmits it to XIV Launcher?

The flow would be basically: user opens app -> app requests OS for the user to authenticate themselves using biometrics -> user authenticates -> app unlocks

And for failure: user opens app -> app requests OS for the user to authenticate themselves using biometrics -> user fails to authenticate -> app offers a button to try again
@goaaats goaaats added enhancement New feature or request help wanted Extra attention is needed labels Jul 3, 2022
@Berna-L
Copy link
Author

Berna-L commented Mar 20, 2023

Grabbing this.

Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Mar 20, 2023
@Berna-L
goaaats#15: First version of biometrics option.
38d3a83
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Mar 21, 2023
@Berna-L
goaaats#15: Authentication always works if there's no biometrics avai…
49597ec 
…lable.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Mar 21, 2023
@Berna-L
goaaats#15: Add Face ID description (so it works) + restrict authenti…
2a5137b 
…cation to biometrics only.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 3, 2023
@Berna-L
goaaats#15: Mostly Android-related changes:
81b6512 
- Update SDK version
- Change MainActivity superclass to FlutterFragmentActivity (see https://pub.dev/documentation/local_auth/latest/ -> Activity Changes)
- Change AndroidManifest.xml to add android:exported="true" (required for Android 12+)
- Do not let user use the application until they authenticate
- Make the biometrics option centered.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 3, 2023
@Berna-L
goaaats#15: Request biometrics again if the app is resumed from backg…
4fd1e3e 
…round.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 3, 2023
@Berna-L
goaaats#15: Add auth guard to settings page.
d8f4291
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 3, 2023
@Berna-L
goaaats#15: Mostly Android-related changes:
4b7fd4c 
- Update SDK version
- Change MainActivity superclass to FlutterFragmentActivity (see https://pub.dev/documentation/local_auth/latest/ -> Activity Changes)
- Change AndroidManifest.xml to add android:exported="true" (required for Android 12+)
- Do not let user use the application until they authenticate
- Make the biometrics option centered.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 3, 2023
@Berna-L
goaaats#15: Request biometrics again if the app is resumed from backg…
f828687 
…round.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 3, 2023
@Berna-L
goaaats#15: Add auth guard to settings page.
67c2acb
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Move all biometrics-related code to biometrics.dart.
c4ab08c
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Require auth check when enabling biometrics auth.
44a88b6 
+ Rename Authentication class to Biometrics.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Require auth check when enabling biometrics auth.
cd90cf0 
+ Rename Authentication class to Biometrics.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: First version of biometrics option.
d40b1a2
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Authentication always works if there's no biometrics avai…
336c3e8 
…lable.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Add Face ID description (so it works) + restrict authenti…
3f66a2c 
…cation to biometrics only.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Mostly Android-related changes:
0358614 
- Update SDK version
- Change MainActivity superclass to FlutterFragmentActivity (see https://pub.dev/documentation/local_auth/latest/ -> Activity Changes)
- Change AndroidManifest.xml to add android:exported="true" (required for Android 12+)
- Do not let user use the application until they authenticate
- Make the biometrics option centered.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Request biometrics again if the app is resumed from backg…
7146217 
…round.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Add auth guard to settings page.
16825c1
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Move all biometrics-related code to biometrics.dart.
6e16c45
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 8, 2023
@Berna-L
goaaats#15: Require auth check when enabling biometrics auth.
ed76cf8 
+ Rename Authentication class to Biometrics.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: First version of biometrics option.
719891b
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: Authentication always works if there's no biometrics avai…
c6610ec 
…lable.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: Add Face ID description (so it works) + restrict authenti…
d34c57a 
…cation to biometrics only.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: Mostly Android-related changes:
01b43ea 
- Update SDK version
- Change MainActivity superclass to FlutterFragmentActivity (see https://pub.dev/documentation/local_auth/latest/ -> Activity Changes)
- Change AndroidManifest.xml to add android:exported="true" (required for Android 12+)
- Do not let user use the application until they authenticate
- Make the biometrics option centered.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: Request biometrics again if the app is resumed from backg…
2e2c9ee 
…round.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: Add auth guard to settings page.
e80c1f0
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: Move all biometrics-related code to biometrics.dart.
f769829
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: Require auth check when enabling biometrics auth.
5681ac3 
+ Rename Authentication class to Biometrics.
Berna-L added a commit to Berna-L/xl-authenticator that referenced this issue Apr 9, 2023
@Berna-L
goaaats#15: Fix behavior of the biometrics checkbox.
f5039ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Berna-L @goaaats