Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safety mechanism to auto-close feature #24

Open
aekobear opened this issue Jan 7, 2024 · 1 comment
Open

Add safety mechanism to auto-close feature #24

aekobear opened this issue Jan 7, 2024 · 1 comment

Comments

@aekobear
Copy link

aekobear commented Jan 7, 2024

The "auto-close app after sending code" feature can be super dangerous. Once activated, it's practically impossible to see the TOTP code before the app closes. There's no way to access app settings to turn it off once it's turned on

TOTP is necessary for accessing secure.square-enix and mog station, so if the user hasn't set up a second TOTP app with the same code, toggling this checkbox could lock them out of their account

Consider implementing a way to access the code or settings even when this option is enabled (android supports custom app menus on long hold)

Failing that, even an in-app warning that users must have a separate app installed before enabling this option would be super helpfull

@tommadness
Copy link

The auto-close feature should only happen after XL-Auth successfully sends the code (read: accepted by XIVLauncher, logging you into the game). If that is not the case, that is a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants