Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows releases #10

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

liamdawson
Copy link

Based on goatcorp/FFXIVQuickLauncher#437 (comment), I figured there was an appetite for Windows builds.

Changes

  • Update flutter_secure_storage to 5.0.2 (introducing Windows support)
  • Add a Windows flutter target
  • Hide the QR code scanner on the "Set-Up OTP" page
    • Not supported on Windows at this time
  • Show the App Bar on the QR code scanner page on Windows
    • No way to cancel out to navigate back, otherwise
  • Make the logo flex (so it doesn't hide the bottom controls if the window is too wide)
  • Add a Powershell script to prepare Windows releases (Powershell due to built-in archiving support)

Notes/Discussion

  • I feel like we could do a lot for the UI on Windows, but I didn't want to introduce potentially unwelcome changes in this PR

  • How should OTP setup work on Windows in the longer term?

  • Should the IP address default to 127.0.0.1 on Windows? I feel like that would avoid "it's not working" messages in future

  • Sounds like we're in somewhat unsupported territory - the Flutter docs note:

    We don’t recommend releasing a desktop application until desktop support is stable

  • I've only tried this on Windows 10, and only on the same machine I built the app on

Screenshots

image
image

@liamdawson
Copy link
Author

For those who're brave enough to try it, here's a release zip built from ec05a16.

xl_otpsend-windows.ec05a16.zip

@alphaONE2
Copy link
Contributor

This works just fine on my Windows 11 box.

@mkolassa
Copy link

mkolassa commented Dec 3, 2021

Tested as working on my Windows 11 desktop as well.

@Pilzinsel64
Copy link

Works fine, really really nice! 👌
The only thing is that "Close after sent" doesn't work. But that's ok as it's a first test build and how different Android and Windows works at this point.

@liamdawson
Copy link
Author

@Pilzinsel64 looks like there's no easy and clean way to accomplish that. I'll try doing an easy and dirty way to do it, and will otherwise fall back to taking the option out entirely (if it's not going to work).

@Pilzinsel64
Copy link

@liamdawson Alright! 👍
As long as the process get closed, it's alright. Otherwise, just get rid of that option (like you did with the QR code scanner) sounds ok for here, I guess.

@liamdawson
Copy link
Author

liamdawson commented Dec 8, 2021

Release zip from f39ccab, fixes auto-close on my machine. Guess the queue times on Tonberry have some advantages 😅

xl_otpsend-windows.f39ccab.zip

@Pilzinsel64
Copy link

That's really a simple fix. 😁 But works well! 👍

@mkolassa
Copy link

mkolassa commented Feb 9, 2022

Looks like Flutter has added stable Windows support as of a few days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants