Use HTTPName for cookies in response encoders #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
force-pushed
the
dev/cookie-http-name
branch
from
106e4d2
to
c59d563
Compare
|
That makes sense, thank you! Would you mind rebasing onto the latest v3, that should fix the build hopefully... |
I believe this was an oversight in 27c249f (included in v3.12.0 and newer), breaking cookie name mapping to some extent. The upgrade to v3.12.1 in the cookie example shows how the name assigned to the cookie inadequately changes from `SID` (cookie name) to session_id` (attr name). goadesign/examples@45ca835#diff-c31b43a7b7656de4c0d63b7ac526bfbad82aa335c79f08e186f5d78c6ddc0802R97
sevein
force-pushed
the
dev/cookie-http-name
branch
from
c59d563
to
2831e38
Compare
|
Works now, thank you @raphael! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was an oversight in 27c249f (included in v3.12.0 and newer),
breaking cookie name mapping to some extent.
The upgrade to v3.12.1 in the cookie example shows how the name assigned to the
cookie inadequately changes from
SID(cookie name) to session_id` (attr name).goadesign/examples@45ca835#diff-c31b43a7b7656de4c0d63b7ac526bfbad82aa335c79f08e186f5d78c6ddc0802R97