Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion methods to use correct external type #3607

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

tchssk
Copy link
Member

@tchssk tchssk commented Oct 28, 2024

#3605

It seems that Goify() is also applied to external types and their names change.
I implemented using struct:type:name, but there may be a more better way.

@tchssk tchssk marked this pull request as ready for review October 28, 2024 16:20
@raphael
Copy link
Member

raphael commented Oct 29, 2024

This approach looks good to me, it's consistent with how we've used the struct:type:name to coerce the generated type in other places. Also it's low risk since there should be no other generated code that manipulates the external type. Thank you for the fix!

@raphael raphael merged commit 405ca1c into goadesign:v3 Oct 29, 2024
11 checks passed
@tchssk tchssk deleted the issue-3605 branch October 29, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants