Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New goals screen #33

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

New goals screen #33

wants to merge 5 commits into from

Conversation

OliverLSanz
Copy link
Collaborator

Change the existing Goals screen to make each goal list item an accordion that can be expanded to show that goal's activities.

@OliverLSanz
Copy link
Collaborator Author

I think there are layout issues that makes the screen difficult to understand without paying close attention to it. They should be resolved.

  • The "Activities" header appears with the same layout of a list item. IMO because of this it can be confused with another goal or activity.
  • If we reduce the size of the "Activities" header, it would be good to replace it or add an actual list item to empty goals, that reads something like: "Add first activity".
  • The only thing that visually differentiates the goal list from the inner activity lists are dividers placed at the boundaries of the activity lists. This visual differentiation is not enough, specially when there are two activity lists expanded at the same time as seen in the screenshot.
  • Probably it should not be possible to have two Goals expanded at the same time.

@OliverLSanz
Copy link
Collaborator Author

Another thing: the Goal Screen does not make any sense (related to the new Goals Screen) because it basically has the same content.

But it can't be removed either, because that is the only (obvious) place when we can:

  • View the motivation
  • Edit the goal (also present in long press menu of GoalsListItem)
  • View archived activities (also present in long press menu of GoalsListItem)
  • Archive the goal (also present in long press menu of GoalsListItem)

If it wasn't for the motivation, a three dots menu with all those actions could be added to the GoalsListItem to completely remove the GoalsScreen.

We also need to have in mind that future extensions to goals that could make the Goal Screen necessary are possible (and probably give it content to differentiate from the content present in the Goals Screen).

@OliverLSanz
Copy link
Collaborator Author

We could merge this screen before polishing it, to do some testing of it integrated with the recent changes. But for this we should be able to switch back to the old screen easily. We should modify this changes so that they don't destruct the previous version.

- Restricted to one expanded item at the same time.
- Added color highlight to expanded item.
@JimenaAndrea JimenaAndrea marked this pull request as draft October 29, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants