Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardizing tags #373

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Standardizing tags #373

merged 3 commits into from
Sep 22, 2023

Conversation

inquisitev
Copy link
Contributor

@inquisitev inquisitev commented Sep 21, 2023 •
edited
Loading

#372

  • find and replace of the variants
  • static analysis script

@inquisitev
Add GH action to enforce @SInCE release vX.X.X, replace all offending
29a230d 
replace all tags

add action

add comments to action

typo on return var

dont local

exit 1 with no ret

fix since syntax

use bashxargs

should fail test

exit zero when passing, 1 when failing

clean last tags

changelog
@inquisitev inquisitev marked this pull request as ready for review September 21, 2023 21:50
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (7a8c928) 91.55% compared to head (1d3b74c) 91.61%.
Report is 1 commits behind head on latest.

Additional details and impacted files 
@@            Coverage Diff             @@
##           latest     #373      +/-   ##
==========================================
+ Coverage   91.55%   91.61%   +0.06%     
==========================================
  Files          43       43              
  Lines        3658     3698      +40     
  Branches      474      479       +5     
==========================================
+ Hits         3349     3388      +39     
  Misses        216      216              
- Partials       93       94       +1

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

goatshriek
goatshriek requested changes Sep 22, 2023
View reviewed changes
Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for putting this together! Only a few minor tweaks needed, and then this will be ready to go.

.github/workflows/analysis.yml Outdated Show resolved Hide resolved
.github/workflows/analysis.yml Outdated Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
@goatshriek goatshriek self-assigned this Sep 22, 2023
@inquisitev
Add GH action to enforce @SInCE release vX.X.X, replace all offending
eb68750 
replace all tags

add action

add comments to action

typo on return var

dont local

exit 1 with no ret

fix since syntax

use bashxargs

should fail test

exit zero when passing, 1 when failing

clean last tags

changelog
@inquisitev
Copy link
Contributor Author

dang i messed up that amend...eb68750

@goatshriek goatshriek merged commit ce6689d into goatshriek:latest Sep 22, 2023
45 checks passed
@goatshriek goatshriek added the hacktoberfest-accepted accepted work that is valid for hacktoberfest label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goatshriek goatshriek goatshriek approved these changes

Assignees

@goatshriek goatshriek

Labels
hacktoberfest-accepted accepted work that is valid for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inquisitev @goatshriek