Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added benchmark score for PrivalFromString (#378) #379

Merged

Conversation

kirubaspace
Copy link
Contributor

This adds benchmark testing for PrivalFromString. This is intended to compare benchmarking score for reference in the future if further optimisations/changes done in the corresponding function.

image

Make sure that your pull request follows the guidelines specified in the
Guidelines for Contributing.

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for putting this together! I've included a few comments for you to address, after which I will run the CI tests.

CMakeLists.txt Outdated Show resolved Hide resolved
benchmark/src/benchmark/cmake/Modules/FindLLVMAr.cmake Outdated Show resolved Hide resolved
test/performance/priority.cpp Outdated Show resolved Hide resolved
test/performance/priority.cpp Outdated Show resolved Hide resolved
@goatshriek goatshriek self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c54a498) 91.69% compared to head (ba4615f) 91.78%.
Report is 3 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #379      +/-   ##
==========================================
+ Coverage   91.69%   91.78%   +0.09%     
==========================================
  Files          44       44              
  Lines        3743     3772      +29     
  Branches      489      497       +8     
==========================================
+ Hits         3432     3462      +30     
  Misses        216      216              
+ Partials       95       94       -1     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now! The final thing for you to correct is simply add an include for <string> to priority.cpp (due to the usage of std::string), which should satisfy the include check in the Static Analysis workflow.

@goatshriek goatshriek added the hacktoberfest-accepted accepted work that is valid for hacktoberfest label Oct 16, 2023
@goatshriek goatshriek merged commit 67cf413 into goatshriek:latest Oct 16, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted accepted work that is valid for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants