-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the turkish localization #389
Added the turkish localization #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for contributing this! Just two changes to make, the first listed below. The second is to add a new section to the .github/workflows/locale.yml
for the new translation. Commit 5529e07 has a good example of how to make this change if you need something to look at for comparison.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #389 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 44 44
Lines 3776 3776
Branches 497 497
=======================================
Hits 3466 3466
Misses 216 216
Partials 94 94 ☔ View full report in Codecov by Sentry. |
Sry about that, i have 2 repos to keep the contributing repo clean and looks like i made some of the changes to other repo :D. Anyways i fixed locale in cmakelists and also added the tr section to locale.yml file. Let me know if there is anything else. |
Looks like there's just one more thing to check - at least one line is longer than 80 characters. Once you've broken that up this should be all good to go. |
There shouldn't be any line longer than 80 characters now, is there anything else? |
Solution for this issue: #388 (comment)
Implemented turkish localization as described here