Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the turkish localization #389

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

OsmanBuyuksar
Copy link
Contributor

Solution for this issue: #388 (comment)

Implemented turkish localization as described here

@goatshriek goatshriek added the l10n localization of stumpless label Nov 2, 2023
Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing this! Just two changes to make, the first listed below. The second is to add a new section to the .github/workflows/locale.yml for the new translation. Commit 5529e07 has a good example of how to make this change if you need something to look at for comparison.

CMakeLists.txt Outdated Show resolved Hide resolved
@goatshriek goatshriek self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80a1d6e) 91.79% compared to head (0ae644f) 91.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest     #389   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files          44       44           
  Lines        3776     3776           
  Branches      497      497           
=======================================
  Hits         3466     3466           
  Misses        216      216           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OsmanBuyuksar
Copy link
Contributor Author

OsmanBuyuksar commented Nov 2, 2023

Sry about that, i have 2 repos to keep the contributing repo clean and looks like i made some of the changes to other repo :D. Anyways i fixed locale in cmakelists and also added the tr section to locale.yml file. Let me know if there is anything else.

@goatshriek
Copy link
Owner

Looks like there's just one more thing to check - at least one line is longer than 80 characters. Once you've broken that up this should be all good to go.

@OsmanBuyuksar
Copy link
Contributor Author

There shouldn't be any line longer than 80 characters now, is there anything else?

@goatshriek goatshriek merged commit cd37149 into goatshriek:latest Nov 2, 2023
49 checks passed
@goatshriek goatshriek added the hacktoberfest-accepted accepted work that is valid for hacktoberfest label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted accepted work that is valid for hacktoberfest l10n localization of stumpless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants