Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for Albanian (sq-AL) #395

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

heavylemon1
Copy link
Contributor

This pull request solves #324 by adding localization support for the 🇦🇱 Albanian language (sq-AL).
There are some terms which don't have a very descriptive translation in Albanian, for which I also included the English term for better readability.
Let me know if you have any further questions or if something doesn't check out.
Thanks!

@goatshriek goatshriek self-assigned this Dec 13, 2023
@goatshriek goatshriek added the l10n localization of stumpless label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e66fdae) 90.48% compared to head (fbaeb92) 90.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest     #395   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files          46       46           
  Lines        4160     4160           
  Branches      553      553           
=======================================
  Hits         3764     3764           
  Misses        273      273           
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goatshriek
Copy link
Owner

Thanks very much for putting this together, it looks great! You just need to break up the lines that are longer than 80 characters, and this should be good to accept.

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break up lines longer than 80 characters so that static analysis passes.

@heavylemon1
Copy link
Contributor Author

Hello @goatshriek ,
Just divided the strings that failed the checks to several lines
Let me know if there are more improvements to be made!

@goatshriek goatshriek merged commit cbfe354 into goatshriek:latest Dec 15, 2023
51 checks passed
@goatshriek
Copy link
Owner

Thank you once again for putting this localization together! It is greatly appreciated.

@heavylemon1
Copy link
Contributor Author

You're welcome @goatshriek !
Appreciate the opportunity as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n localization of stumpless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants