Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues with babel core on a fresh install and addressing batch test failures #706

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing issues with babel core on a fresh install and addressing batch test failures #706

wants to merge 1 commit into from

Conversation

jdollar
Copy link

@jdollar jdollar commented Jan 7, 2017

Running into this issue when running a new 'npm intall':

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.dirname (path.js:1324:5)
    at /Users/jdollar/personalrepos/alt/node_modules/babel-core/lib/transformation/file/options/option-manager.js:353:36
    at /Users/jdollar/personalrepos/alt/node_modules/babel-core/lib/transformation/file/options/option-manager.js:375:22
    at Array.map (native)
    at OptionManager.resolvePresets (/Users/jdollar/personalrepos/alt/node_modules/babel-core/lib/transformation/file/options/option-manager.js:364:20)
    at OptionManager.mergePresets (/Users/jdollar/personalrepos/alt/node_modules/babel-core/lib/transformation/file/options/option-manager.js:348:10)
    at OptionManager.mergeOptions (/Users/jdollar/personalrepos/alt/node_modules/babel-core/lib/transformation/file/options/option-manager.js:307:14)
    at /Users/jdollar/personalrepos/alt/node_modules/babel-core/lib/transformation/file/options/option-manager.js:349:14
    at /Users/jdollar/personalrepos/alt/node_modules/babel-core/lib/transformation/file/options/option-manager.js:369:24

The package.json babel-core upgrade came from these:
Original issue with the fix: webpack/webpack#2463
Linked issue in babel-core: babel/babel#4306

In addition to the install failing there were also two tests failing for the batch dispatch tests. Had a "TODO" comment stating nothing was getting dispatched and the error I was getting was:

ReferenceError: An action was called but nothing was dispatched-_-_-_-_-_-_-_-_-_-_,------,
    at Object.warn (/Users/jdollar/personalrepos/alt/lib/utils/AltUtils.js:52:18)-_|   /\_/\
    at Object.action [as buttonClick] (/Users/jdollar/personalrepos/alt/lib/actions/index.js:54:13)
    at Context.doesNotBatch (/Users/jdollar/personalrepos/alt/test/batching-test.js:93:27)
    at callFnAsync (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:349:8)
    at Test.Runnable.run (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:301:7)
    at Runner.runTest (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:422:10)
    at /Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:528:12
    at next (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:342:14)
    at /Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:352:7
    at next (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:284:14)
    at /Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:315:7
    at done (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:287:5)
    at callFn (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:344:7)
    at Hook.Runnable.run (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:319:7)
    at next (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:298:10)
    at Immediate.<anonymous> (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:320:5)
    at runCallback (timers.js:649:20)
    at tryOnImmediate (timers.js:622:5)
    at processImmediate [as _immediateCallback] (timers.js:594:5)
ReferenceError: An action was called but nothing was dispatched-_-_-_-_-_-_-_-_-_-__,------,
    at Object.warn (/Users/jdollar/personalrepos/alt/lib/utils/AltUtils.js:52:18)-__|  /\_/\
    at Object.action [as buttonClick] (/Users/jdollar/personalrepos/alt/lib/actions/index.js:54:13)
    at Context.allowsBatching (/Users/jdollar/personalrepos/alt/test/batching-test.js:107:27)
    at callFnAsync (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:349:8)
    at Test.Runnable.run (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:301:7)
    at Runner.runTest (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:422:10)
    at /Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:528:12
    at next (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:342:14)
    at /Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:352:7
    at next (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:284:14)
    at /Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:315:7
    at done (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:287:5)
    at callFn (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:344:7)
    at Hook.Runnable.run (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runnable.js:319:7)
    at next (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:298:10)
    at Immediate.<anonymous> (/Users/jdollar/personalrepos/alt/node_modules/mocha/lib/runner.js:320:5)
    at runCallback (timers.js:649:20)
    at tryOnImmediate (timers.js:622:5)
    at processImmediate [as _immediateCallback] (timers.js:594:5)

Updated the batch test file to just dispatch a null in addition to getting dispatched from the timeout.

@jdollar
Fixing issues with babel core with a fresh install and test failures
9d52427 
Installed a newer version of babel to fix a path undefined error when running babel src.
The issue was identified and resolved in the newer versions of babel core.

Updated failing tests for batching actions. For the test cases the button click
action was not dispatching anything and only setting a timeout.
Instead just made it return a null when the actions are called so it will
dispatch a null when those actions are called in addition to dispatching.
a action when the timeout runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"TypeError: Path must be a string" after break from project
1 participant
@jdollar