Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Babel, Webpack, React, Eslint, etc to latest & Clean up linting errors #719

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"presets": ["airbnb", "stage-0"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep this as-is

"presets": ["env", "babel-preset-react", "babel-preset-stage-0"],
"plugins": [
"add-module-exports",
"transform-class-properties",
Expand Down
23 changes: 17 additions & 6 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,23 @@
"browser": true,
"es6": true
},
"parser": "babel-eslint",
"ecmaFeatures": {
"modules": true,
"jsx": true
},
"rules": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, can we revert this file to include only the single rule. We can perhaps add individual overrides per line.

no-param-reassign can be easily fixed by renaming all the reducers from obj to acc (acc is whitelisted as an acceptable param that can be reassigned)

"comma-dangle": [2, "never"],
"semi": [2, "never"],
}
"arrow-body-style": [2, "always"],
"class-methods-use-this": 0,
"no-console": 0,
"no-param-reassign": 0,
"func-names": 0,
"no-restricted-syntax": 0,
"no-plusplus": 0,
"no-continue": 0,
"no-prototype-builtins": 0,
"prefer-rest-params": 0,
"no-unused-vars": [2, { "args": "none" }],
"no-underscore-dangle": 0,
"react/jsx-filename-extension": 0,
"react/forbid-prop-types": 0,
},
"parser": "babel-eslint"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think we need this, but we may need it for some stage-0 features. I'd happily .eslintignore anything that is stage0 though, since it's supposed to be experimental

}
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 1.0.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no not yet.


* Upgrade babel, webpack, react versions to latest

## 0.18.6

* Fixes inheritance for actions #678
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class TodoStore {
export default alt.createStore(TodoStore, 'TodoStore');
```

View
View

Using the [connectToStores](https://github.com/altjs/utils/blob/master/src/connectToStores.js) util from [alt-utils](https://github.com/altjs/utils) package (`npm install alt-utils`)

Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"description": "Alt is a flux implementation that is small (~4.3kb & 400 LOC), well tested, terse, insanely flexible, and forward thinking.",
"main": "dist/alt.js",
"devDependencies": {
"babel": "^4.0.1",
"babel": "^6.25.0",
"coveralls": "^2.11.2",
"istanbul": "^0.3.5",
"mocha": "^2.1.0"
Expand Down
12 changes: 6 additions & 6 deletions dist.config.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
module.exports = {
context: __dirname + '/src',
context: `${__dirname}/src`,
entry: {
'alt': ['./index.js'],
alt: ['./index.js']
},
output: {
path: __dirname + '/dist',
path: `${__dirname}/dist`,
filename: '[name].js',
library: 'Alt',
libraryTarget: 'umd'
},
module: {
loaders: [{
test: /\.js$/,
loader: 'babel',
loader: 'babel-loader',
exclude: /node_modules/
}]
},
};
}
}
12 changes: 6 additions & 6 deletions dist.min.config.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
module.exports = {
context: __dirname + '/src',
context: `${__dirname}/src`,
entry: {
'alt': ['./index.js'],
alt: ['./index.js']
},
output: {
path: __dirname + '/dist',
path: `${__dirname}/dist`,
filename: '[name].min.js',
library: 'Alt',
libraryTarget: 'umd'
},
module: {
loaders: [{
test: /\.js$/,
loader: 'babel',
loader: 'babel-loader',
exclude: /node_modules/
}]
},
};
}
}
Loading