Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed memory leak #725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed memory leak #725

wants to merge 1 commit into from

Conversation

roths
Copy link

@roths roths commented May 9, 2018

No description provided.

@CrazyPython
Copy link

@goatslacker could you retry the Travis build? It appears to be failing because of something unrelated to the PR.

@matsjoyce
Copy link

To completely fix this issue you need to patch the function returned from Store.listen as well. +1 though, this was causing a huge memory leak in my app.

@jacaetevha
Copy link

This fix is really needed for our project. Is there any chance it will get merged, or do we need to just fork and apply the PR to our own fork? I'd rather not have to do that.

@matsjoyce
Copy link

This PR has been sitting here for over a year already, so I wouldn't wait for it to be merged.

@davidosomething
Copy link

i made the fix to the Store.listen in #736

Repository owner deleted a comment from chasedson Feb 7, 2024
Repository owner deleted a comment from diego-gutlop Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants