Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: komga: document #12476

Merged

Conversation

4d62
Copy link
Contributor

@4d62 4d62 commented Dec 24, 2024

sdko/feat/integration/pickup-4139-komga

Details

Documents the https://komga.org integration by updating the abandoned PR.

This is PR 1 of 2 as I divided 4139 in 2

Closes #4139


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

4d62 added 6 commits December 23, 2024 21:30
Adds the Komga integration to the sidebar

Signed-off-by: 4d62 <github-user@sdko.org>
Rewrite previous documentation. Update YML to new format as per the example in the [advanced configuration documentation](https://komga.org/docs/installation/oauth2/#advanced-configuration). Just a few changes

Signed-off-by: 4d62 <github-user@sdko.org>
… default

Updates the default `user-name-attribute` from `sub` to `preferred_username` (I would assume that's what users prefer if there's collaboration, idk) & adds a warning similar to what I did in that latest Mastodon MR.

Signed-off-by: 4d62 <github-user@sdko.org>
Fixes markdown for service link and updates `authentik.company` placeholder.

Signed-off-by: 4d62 <github-user@sdko.org>
Restructures the "authentik configuration" section and updates the first sentence of the "Komga configuration" section

Signed-off-by: 4d62 <github-user@sdko.org>
Lints modified file with Prettier.

Signed-off-by: 4d62 <github-user@sdko.org>
@4d62 4d62 requested a review from a team as a code owner December 24, 2024 02:54
Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 1db5244
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6776bd9879f1ff00080d0e42
😎 Deploy Preview https://deploy-preview-12476--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 1db5244
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6776bd98dd9f3b00084b332d
😎 Deploy Preview https://deploy-preview-12476--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Accidentally removed bold from step 1 of "authentik configuration". This fixes the issue.

Signed-off-by: 4d62 <github-user@sdko.org>
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (d4e15f0) to head (1db5244).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12476      +/-   ##
==========================================
+ Coverage   92.68%   92.75%   +0.06%     
==========================================
  Files         770      770              
  Lines       38873    38873              
==========================================
+ Hits        36031    36058      +27     
+ Misses       2842     2815      -27     
Flag Coverage Δ
e2e 48.70% <ø> (+0.10%) ⬆️
integration 24.58% <ø> (ø)
unit 90.38% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Others don't have it so this one should not

Signed-off-by: 4d62 <github-user@sdko.org>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @4d62 for this PR, especially as it helps us clean out older/abandoned PRs.

It would be great to have a final verification step at the end of the integration guide. Een a single sentence saying how to launch, etc.

4d62 added a commit to 4d62/authentik that referenced this pull request Dec 27, 2024
Updates the preparation placeholder everywherefollowing the review comment at goauthentik#12476 (comment)
Addresses comments & applies suggestions from the first review round.
@4d62 4d62 requested a review from tanberry December 27, 2024 19:50
@4d62
Copy link
Contributor Author

4d62 commented Dec 27, 2024

Please do let me know if there's anything else.

@tanberry
Copy link
Contributor

tanberry commented Dec 27, 2024

Please do let me know if there's anything else.

Hi hi, what are your thoughts about adding a last step for verification that the integration worked, @4d62 ?

@4d62
Copy link
Contributor Author

4d62 commented Dec 27, 2024

Sorry forgot to click "Send" @tanberry

IMO, For most integrations, the process involves logging out and back in with authentik, so it might not be worth explicitly stating.

@4d62
Copy link
Contributor Author

4d62 commented Dec 27, 2024

A note could be added for special cases, but there would be one or two exceptions max

@tanberry
Copy link
Contributor

A note could be added for special cases, but there would be one or two exceptions max

Ah, could to know that in most cases it is a simple process of logging out and then back in. We can add that simple sentence to the template, then, and it will just be there. I do think it is important to have it in the integration guide... and in the scenarios where it is more complex, having that line in the template will help people remember to explain the verification process if complicated.

tanberry pushed a commit that referenced this pull request Dec 30, 2024
Updates the preparation placeholder everywherefollowing the review comment at #12476 (comment)
@4d62
Copy link
Contributor Author

4d62 commented Dec 30, 2024

Seems like a good idea. Unless there's anything else this seems ready to merge and I'll open a PR to add that line.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sounds like you plan to open a subsequent PR to add the verification step?

@4d62
Copy link
Contributor Author

4d62 commented Jan 2, 2025

Yes, I will

@tanberry tanberry merged commit e3011ea into goauthentik:main Jan 2, 2025
67 checks passed
@4d62 4d62 deleted the sdko/feat/integration/pickup-4139-komga branch January 2, 2025 22:03
kensternberg-authentik added a commit that referenced this pull request Jan 8, 2025
* main:
  core: bump github.com/getsentry/sentry-go from 0.30.0 to 0.31.1 (#12543)
  core: bump google-api-python-client from 2.156.0 to 2.157.0 (#12544)
  core: bump ruff from 0.8.4 to 0.8.5 (#12545)
  core: bump msgraph-sdk from 1.15.0 to 1.16.0 (#12546)
  Update index.mdx (#12542)
  web: fix source selection and outpost integration health (#12530)
  Ading a step to paperless guide (#12539)
  website/integrations: Semaphore (#12515)
  website/integrations: komga: document (#12476)
  website/integrations: fix missing quote in paperless-ngx (#12537)
  website/integrations: cloudflare access: upd placeholder for saas (#12536)
  website/integrations: veeam-enterprise-manager: don't hardcode helpcenter doc version (#12538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants