Commits on Jun 11, 2020

1. Iterate user table in a sorted way, fix tests with latest glib …

   This is primarily to help test cases which assume that the adopted algorithm
   prioritizes the users in the exact reverse order they appear in the test
   cases (and get inserted into the session in reverse order). With older glib
   version, the five users being inserted happened to return the order expected by
   the tests. With latest glib, due to a minor tweak in hashing strategy, the
   insertion leads to unsorted list leading to failed tests.
   
   In addition, GHashTable makes no guarantees about the stability of items when
   iterating multiple times. Since the algorithm is sensitive to order of users, it
   is best to return users in an order that is consistent over multiple calls and
   stable over insert/remove operations.
   
   This patch maintains a sorted list of user ids and uses it for iteration.
   
   Closes: gobby#22.
   
   Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>

   

   SunilMohanAdapa committed Jun 11, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for ebe92d9
   • Browse repository at this point

   Copy the full SHA

   ebe92d9 View commit details

   Browse the repository at this point in the history