Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Laravel Nova 4.0 Support #69

Open
h888t opened this issue Apr 5, 2022 · 19 comments
Open

Laravel Nova 4.0 Support #69

h888t opened this issue Apr 5, 2022 · 19 comments

Comments

@h888t
Copy link

h888t commented Apr 5, 2022

  Problem 1
    - gobrightspot/nova-detached-actions is locked to version 1.1.1 and an update of this package was not requested.
    - gobrightspot/nova-detached-actions 1.1.1 requires laravel/nova ^3.0 -> found laravel/nova[dev-master, v3.0.0, ..., 3.x-dev (alias of dev-master)] but it conflicts with your root composer.json require (~4.0).
   

when updating to Laravel Nova v4.

@ibrahem-kamal
Copy link

i dont think its gonna be updated as nova 4 has already this feature implemented

link for documentation

@centgart
Copy link

@ibrahem-kamal trouble is that Nova 4 still shows standalone action within the action dropdown, and the good thing this package adds is an ability to make separate action button next to Create Resource button.
Less clicks for heavily used actions, better UI.

@RenoLooijmans
Copy link

Bump. Would like to have this package work for Nova 4 as well.

@vesper8
Copy link

vesper8 commented Jul 13, 2022

This fork has Nova 4 support

https://github.com/lucidlogic/nova-detached-actions

@lucidlogic Any chance you could take all of your awesome changes in your fork and submit a PR?

@RenoLooijmans
Copy link

RenoLooijmans commented Jul 15, 2022

This fork has Nova 4 support

https://github.com/lucidlogic/nova-detached-actions

@lucidlogic Any chance you could take all of your awesome changes in your fork and submit a PR?

Are you sure his fork works for Nova 4? I have tried it but I couldn't get it to work...

@georgep-am
Copy link

I have also tried to install the fork but couldn't get it to work. Is there anything I may be missing?

@Hemnyos
Copy link

Hemnyos commented Aug 3, 2022

yea, the "composer require gobrightspot/nova-detached-actions" doesnt work at all 😅

@ali-raza-saleem
Copy link
Contributor

I have created PR for Nova 4 Update. Tested all the features. Working as expected.
#74

@matthewhutchings
Copy link

Please review PR above.

@adrianmihaila
Copy link

adrianmihaila commented Sep 5, 2022

I have created PR for Nova 4 Update. Tested all the features. Working as expected. #74

Hi @the-alichemist. I saw that your PR was merged. Can you please create a tag for this new version? Thanks a lot.

@adrianmihaila
Copy link

adrianmihaila commented Sep 7, 2022

Also, I found an issue. If I disable the standalone property from a detached action, and I show that action onlyOnIndexToolbar when you select one or two resources for example from the listing and click on the detached action button, on:

public function handle(ActionFields $fields, Collection $resources) {}

you will get all resources. Like you pressed on the select all checkbox. Is there anyone that noticed this issue?

@adrianmihaila
Copy link

I created a PR for the issue: #75

@jjjrmy
Copy link

jjjrmy commented Nov 13, 2022

Is there any way to put the button next to the others?
Screen Shot 2022-11-13 at 4 21 04 PM

@mrleblanc101
Copy link

Since #75 has been merged, what are we waiting for to create a new release ?

@vesper8
Copy link

vesper8 commented Dec 22, 2022

#75 doesn't look merged to me...

@mrleblanc101
Copy link

mrleblanc101 commented Dec 22, 2022

@vesper8 I meant #74, which include Nova 4 support

@vesper8
Copy link

vesper8 commented Dec 22, 2022

Ah right.. well I agree with you, a new tag would be nice. I've just been using "gobrightspot/nova-detached-actions": "dev-master", for a while now and it does work great.

@d00p
Copy link

d00p commented Jan 12, 2023

@jjjrmy i got the same issue...rest seems to work just fine

@wajeht
Copy link

wajeht commented Mar 28, 2023

Is there any way to put the button next to the others? Screen Shot 2022-11-13 at 4 21 04 PM

@jjjrmy i got the same issue...rest seems to work just fine

same here, did you guys figured out?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests