Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

最近的96号pr的大改动导致大部分例子点进去都是空的了 #98

Open
law52525 opened this issue Sep 5, 2024 · 0 comments

Comments

@law52525
Copy link

law52525 commented Sep 5, 2024

找出的一些问题:

  1. exampleID后面没有加.html后缀导致github page变成下载了(之前是有.html后缀的)。
  2. index从中文变回英文了。
  3. examples.txt里面每一行的格式完全不解析导致含中文的例子没加载出来最后的页面都是空的。

#96 仔细一看就一大堆问题,把前人很多已经做好的工作都搞乱了,还是认真code review一下自己跑一下测试一下再合master分支吧,还好最后没build出来,不然 https://gobyexample-cn.github.io 都跟着出问题了。

@law52525 law52525 changed the title 最近的96号pr的大改动导致有些例子点进去都是空的了 最近的96号pr的大改动导致大部分例子点进去都是空的了 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant