Add from state method to transition history #493
+29
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al_transition Add transition for initial state
…transition Add from state method to transition history
dylan-hoefsloot
force-pushed
the
feature/add_from_state_to_transition
branch
from
d85e999 to
a14b34c
Compare
dylan-hoefsloot
force-pushed
the
feature/add_from_state_to_transition
branch
from
a14b34c to
8e9c04d
Compare
|
Hey @stephenbinns, Any chance you could give this a look over |
|
The rubocop warnings that are causing the tests to fail are false positives, there are a bunch of new issues today on the rubocop project highlighting the same issue with the new We can either wait for it to be fixed there, downgrade rubocop or ignore these warnings for now. |
|
I'd love this to be merged in. Anything stopping it? |
|
@simmerz When I left off, it just needed a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work of marclerodrigues in No easy way to find previous state.
One of the concerns was:
This PR adds checks to see if the column exists before querying it, therefore users who have not added this column will be able to continue with existing behaviour. This means that this is not a breaking change.
Persisting this information means that accessing it is faster and easier and avoid problems such as mentioned in this comment and the issue containing it.