Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use html and/or backticks in resources properties descriptions? #108

Open
eri-trabiccolo opened this issue Oct 15, 2019 · 5 comments
Open
Assignees
Labels
Type: Documentation Issue related to documentation Type: Question This issue is a question
Milestone

Comments

@eri-trabiccolo
Copy link
Contributor

This is the hamletic question afflicting me and @pondermatic on slack!

James says:

I just searched the output of /wp-json and found NO markup in descriptions. Nothing says to not use markup, but the convention seems to be not to use markup.

but we also found that no backticks are used as well.

James:

Since the schema is mostly meant to be machine readable, the description field is not usually going to be used. Developers may look at it. Maybe someone has written a tool to take the output and turn it into a HTML document, sort of like ReDoc and Swagger-UI. If so, that tool should correctly parse HTML and backticks.
I think backticks are helpful. Too much HTML can make it hard for humans to read though.

Me:

I think you’re right, the only thing is that when it’s about lists, html is useful 😄

James

True.

We both think:

we need a ruling from @thomasplevy

At the moment I used backticks somewhere and html markup somewhere else.

@thomasplevy
Copy link
Contributor

Are we asking about the description field in the spec or in the actual codebase on the description props of endpoints and etc...?

In the spec I think HTML is okay, in the description on the codebase I think it would probably make sense to avoid html.

I think enclosing properties/variables in backticks in the description of the codebase is acceptable, though, if it's causing issues we can easily switch those to quotation marks.

What's "hamletic"?

@thomasplevy thomasplevy added the Type: Question This issue is a question label Oct 15, 2019
@eri-trabiccolo
Copy link
Contributor Author

Sorry, talking about description field in the actual codebase.

OK, so I will make a PR to purge description fields in the codebase from html, and use backticks.

Thanks.

@pondermatic
Copy link
Contributor

hamletic

Interesting word! "undecided".
https://en.wiktionary.org/wiki/Hamletic

@eri-trabiccolo
Copy link
Contributor Author

Oh sorry, I forgot to reply to that.
Well in Italy "hamletic" (amletico, in italian) is a pretty widespread adjective, meaning "undecided" with some tragedy in it :D
And of course refers to Shakespeare's Hamlet.

@thomasplevy
Copy link
Contributor

@eri-trabiccolo sounds good. I think the priority on this is pretty low.

@thomasplevy thomasplevy added this to the Future milestone Oct 15, 2019
@thomasplevy thomasplevy added language: php Type: Documentation Issue related to documentation labels Oct 15, 2019
@thomasplevy thomasplevy moved this to Awaiting Triage in Development Apr 21, 2022
@thomasplevy thomasplevy moved this from Awaiting Triage to Backlog in Development Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Issue related to documentation Type: Question This issue is a question
Projects
Status: Backlog
Development

No branches or pull requests

3 participants