Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document config options for CSAF provider #32

Closed
tschmidtb51 opened this issue Jan 24, 2022 · 3 comments · Fixed by #180
Closed

Document config options for CSAF provider #32

tschmidtb51 opened this issue Jan 24, 2022 · 3 comments · Fixed by #180
Labels
csaf_provider documentation Improvements or additions to documentation

Comments

@tschmidtb51
Copy link
Collaborator

The CSAF provider comes with many options. They should be documented (including their default value) and explained.

@tschmidtb51
Copy link
Collaborator Author

tschmidtb51 commented Jan 24, 2022

https://github.com/csaf-poc/csaf_distribution/blob/44cd02bdc2b953bc825f6d0c674dcd07005fc687/cmd/csaf_provider/config.go#L152

I suggest to also use Example here instead of ACME.

 Name:      func(s string) *string { return &s }("Example"),

@tschmidtb51 tschmidtb51 added csaf_provider documentation Improvements or additions to documentation labels Jan 25, 2022
@tschmidtb51
Copy link
Collaborator Author

@bernhardreiter I just had to re-open that as it was not completed.

@tschmidtb51 tschmidtb51 reopened this Jun 14, 2022
tschmidtb51 added a commit that referenced this issue Jun 14, 2022
@bernhardreiter
Copy link
Member

@tschmidtb51 merged, because it seems to fit your suggested use better. (We had asked back on the "ACME" example, see #40 (comment), this is why I've thought we were already good enough here.) Thanks for doing your suggestion directly as pullrequest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csaf_provider documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants