Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Slack references #612

Merged
merged 2 commits into from
Aug 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions .github/ISSUE_TEMPLATE/question.md

This file was deleted.

14 changes: 4 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,12 @@ project.

No matter how you want to get involved, we ask that you first learn what’s
expected of anyone who participates in the project by reading the Contribution
Guidelines.

**Please Note:** GitHub is for bug reports and contributions primarily - if you
have a support question head over to
[GoDaddy's Open Source Software Slack channel][slack].
Guidelines.

## Answering Questions

One of the most important and immediate ways you can support this project is to
answer questions on [Slack][slack] or [Github][issues]. Whether you’re helping a
answer questions on [Github][issues]. Whether you’re helping a
newcomer understand a feature or troubleshooting an edge case with a seasoned
developer, your knowledge and experience with JS can go a long way to help
others.
Expand Down Expand Up @@ -62,7 +58,7 @@ From a practical perspective, contributions are as simple as:

If you are interested in making a large change and feel unsure about its overall
effect, please make sure to first discuss the change and reach a consensus with
core contributors through [slack]. Then ask about the best way to go about
core contributors. Then ask about the best way to go about
making the change.

## Code Review
Expand All @@ -83,8 +79,7 @@ patches:
to do the same for you. Good will is our currency.
- Split your change into multiple smaller changes. The smaller your change, the
higher the probability that somebody will take a quick look at it.
- Ping the change on [slack]. If it is urgent, provide reasons why it is
important to get this change landed. Remember that you’re asking for valuable
- Remember that you’re asking for valuable
time from other professional developers.

**Note that anyone is welcome to review and give feedback on a change, but only
Expand Down Expand Up @@ -205,7 +200,6 @@ example-directory-name/
- [JSDoc]

[issues]: https://github.com/godaddy/gasket/issues
[slack]: https://godaddy-oss.slack.com/messages/CHXEP5DNH
[JSDoc]: http://usejsdoc.org/
[npm]: http://npmjs.org/
[style]: https://github.com/godaddy/javascript/#godaddy-style
6 changes: 3 additions & 3 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Different levels of consensus are needed for different kinds of changes. For
small PRs, it is sufficient to get the two approvals you need to merge the PR.

For major design additions or refactors, it is more important to get buy-in from
other contributors before starting. Post in the [Slack] channel, and allow a few
other contributors before starting. Post in the [Discussions], and allow a few
days for other contributors to weigh in. Your goal here is to 1) get feedback on
your plan before investing the time in a PR and 2) to get buy-in from other
contributors. Once you have addressed blocking feedback and received some
Expand All @@ -46,7 +46,7 @@ change, allow at least a week for as many maintainers as possible to respond.
Your goal here should be to get buy-in from all maintainers (with silence
interpreted as approval). In rare cases, there may prove to be irresolvable
disagreement between maintainers, in which case it is acceptable to conduct a
majority vote in Slack.
majority vote.

If the design/roadmap change requires a breaking change or major refactor to the
plugin engine or the cli, please tag at least one [code owner][code owners] in
Expand All @@ -61,6 +61,6 @@ working groups:
* Front-end frameworks: e.g. Nextjs, Svelte
* Feature areas: e.g. Intl, lint

[Slack]: https://godaddy-oss.slack.com/archives/CQ6QXC5E1
[Discussions]: https://github.com/godaddy/gasket/discussions
[Gasket Github group]: https://github.com/orgs/godaddy/teams/gasket
[code owners]: ./CODEOWNERS
4 changes: 1 addition & 3 deletions RELEASES.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ do not change the API.

To create a release, please open a release PR that bumps the version number of
any impacted modules as dictated by [Semantic Versioning]. In the PR description,
please enumerate the changes included in the release. Post about the release in
[Slack], and allow for two approvers before merging.
please enumerate the changes included in the release. Allow for two approvals before merging.

[Semantic Versioning]: http://semver.org
[Slack]: https://godaddy-oss.slack.com/messages/CHXEP5DNH
1 change: 0 additions & 1 deletion site/cover.html
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ <h4>Docs</h4>
<div class="footer-links">
<h4>Channel</h4>
<a href="https://blog.gasket.dev">Blog</a>
<a target="_blank" href="https://godaddy-oss-slack.herokuapp.com">Slack</a>
<!-- <a target="_blank" href="https://twitter.com/gasketjs">Twitter</a>-->
<a target="_blank" href="https://stackoverflow.com/questions/tagged/gasket">Stack Overflow</a>
</div>
Expand Down