Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add plugins to environments #638

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

radulle
Copy link
Contributor

@radulle radulle commented Dec 8, 2023

Summary

Small update TypeScript declarations to allow plugins in environments.

Changelog

Test Plan

@radulle radulle requested a review from a team as a code owner December 8, 2023 13:31
Copy link
Contributor

@jpage-godaddy jpage-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be nice to also have a TS test to go with it.

@agerard-godaddy
Copy link
Contributor

@radulle could you add a test to the gasket-typescript-tests package, probably here.

@radulle
Copy link
Contributor Author

radulle commented Dec 19, 2023

@radulle could you add a test to the gasket-typescript-tests package, probably here.

Added a test test to confirm plugins are allowed in environments.

@agerard-godaddy agerard-godaddy merged commit aef0b9c into godaddy:main Jan 19, 2024
4 checks passed
agerard-godaddy pushed a commit that referenced this pull request Jan 24, 2024
* fix(types): add plugins to environments

* fix: test if it allows environments to contain plugins

(cherry picked from commit aef0b9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants