-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring-your-own logger #640
Conversation
- Create a new `@gasket/plugin-logger` to replace `@gasket/plugin-log` - Create `@gasket/plugin-winston` to customize the default logger - Include the new logger plugin by default - Add a per-request logger with updateable metadata - Update the default redux logger to use the per-request logger - Update presets to use the winston logger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some initial comments/questions - Obviously this is going to have some breaking changes so we will need to incorporate into our next major release.
Co-authored-by: Andrew Gerard <63810935+agerard-godaddy@users.noreply.github.com>
I'm excited for this change. Didn't see anything glaring but I would like to confirm - we will no longer need |
Co-authored-by: Michael Mason <105235096+mmason2-godaddy@users.noreply.github.com>
That is correct. |
Co-authored-by: Michael Mason <105235096+mmason2-godaddy@users.noreply.github.com>
Summary
Gasket's logging infrastructure comprises two main parts:
@gasket/plugin-log
: Manages lifecycle timing and executes thelogTransports
hook for adding extra transports to the logger configuration.@gasket/log
: Implements logging using Diagnostics (Client-side) and Winston (Server-side).While these components work together to initialize
gasket.logger
, not all applications utilize them. Additionally, despite Winston's prevalence, we need to be aware of the numerous logging libraries in the ecosystem when adopting Gasket.Updates
@gasket/plugin-logger
to replace@gasket/plugin-log
@gasket/plugin-winston
to customize the default loggerChangelog
Test Plan
Added/updated unit tests.