Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PFX-553] - startServer action, nextjs plugin files, comment out plugin start, createLogger action, update tests #725

Merged
merged 31 commits into from
Apr 12, 2024
Merged

[PFX-553] - startServer action, nextjs plugin files, comment out plugin start, createLogger action, update tests #725

merged 31 commits into from
Apr 12, 2024

Conversation

mmason2-godaddy
Copy link
Contributor

@mmason2-godaddy mmason2-godaddy commented Apr 9, 2024 •
edited
Loading

This PR will probably be adjusted after the base branch is merged.

Summary

  • startServer action
  • devProxy lifecycle & config
  • createLogger action
  • Generate new files from the nextjs plugin
  • Tweak added deps from nextjs plugin
  • Add prompt for server type
  • Temporarily comment out plugin start functionality

Todo

  • Update docs - it seems premature to spend so much time on docs given we have so many moving parts
  • Update nextjs versions to 14 - unsure if we're ready to make this change or if it will happen in this PR
  • Tweak preset dependencies - this will need to happen unsure if it will happen in this PR

Changelog

  • startServer action, nextjs plugin files, comment out plugin start, createLogger action, update tests

Test Plan

  • Updated tests
  • Tested locally with a ton of linking

@mmason2-godaddy mmason2-godaddy requested review from kinetifex and a team as code owners April 9, 2024 16:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
busboy ADDED - 1.6.0
ignore-by-default ADDED - 1.0.1
nodemon ADDED - 3.1.0
pstree.remy ADDED - 1.1.8
simple-update-notifier ADDED - 2.0.0
streamsearch ADDED - 1.1.0
touch ADDED - 3.1.0
undefsafe ADDED - 2.0.5

@agerard-godaddy agerard-godaddy added the version 7 Change targeted for version 7 label Apr 10, 2024
@mmason2-godaddy
Copy link
Contributor Author

Some of the next 14 bumps made it in FYI. I can revert if needed.

agerard-godaddy
agerard-godaddy reviewed Apr 11, 2024
View reviewed changes
packages/gasket-plugin-https/README.md Outdated Show resolved Hide resolved
packages/gasket-plugin-logger/lib/index.js Outdated Show resolved Hide resolved
packages/gasket-plugin-nextjs/lib/create.js Outdated Show resolved Hide resolved
packages/gasket-plugin-nextjs/lib/setup-next-app.js Show resolved Hide resolved
@mmason2-godaddy mmason2-godaddy merged commit a062bb1 into v7 Apr 12, 2024
4 checks passed
@mmason2-godaddy mmason2-godaddy deleted the PFX-553 branch April 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agerard-godaddy agerard-godaddy agerard-godaddy approved these changes

@jpina1-godaddy jpina1-godaddy jpina1-godaddy approved these changes

@kinetifex kinetifex Awaiting requested review from kinetifex

@bbetts-godaddy bbetts-godaddy Awaiting requested review from bbetts-godaddy

@kbader-godaddy kbader-godaddy Awaiting requested review from kbader-godaddy

Assignees
No one assigned
Labels
version 7 Change targeted for version 7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmason2-godaddy @agerard-godaddy @jpina1-godaddy