Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tests that import css #929

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix for tests that import css #929

merged 3 commits into from
Sep 26, 2024

Conversation

jpina1-godaddy
Copy link
Contributor

@jpina1-godaddy jpina1-godaddy commented Sep 25, 2024

Summary

Mocha tests were failing for files that imported css when running tests in app code. This PR adds a css loader to handle css imports for app code.

Exception during run: TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".css" for

Changelog

@gasket/gasket-plugin-mocha

  • Added node-loader-styles node loader
  • Updated register-loader generated file to import styles laoder

Test Plan

  • Tested locally
  • Unit tests

@jpina1-godaddy jpina1-godaddy changed the title feat: added node loader for styles for mocha Fix for tests that import css Sep 26, 2024
@jpina1-godaddy jpina1-godaddy marked this pull request as ready for review September 26, 2024 16:50
@jpina1-godaddy jpina1-godaddy requested a review from a team as a code owner September 26, 2024 16:50
@agerard-godaddy agerard-godaddy merged commit 067bb66 into v7 Sep 26, 2024
1 check passed
@agerard-godaddy agerard-godaddy deleted the add-style-loader-mocha branch September 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants