Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFX-772] Add JSDoc Typechecking to create-gasket-app #943

Merged
merged 11 commits into from
Oct 24, 2024
Merged

Conversation

jpina1-godaddy
Copy link
Contributor

@jpina1-godaddy jpina1-godaddy commented Oct 9, 2024

Summary

Add JSDoc Typechecking to create-gasket-app

Changelog

create-gasket-app

  • Added new types and type file
  • Added typechecking

Test Plan

Added typecheck

@jpina1-godaddy jpina1-godaddy changed the title chore: updated types [PFX-772] Add JSDoc Typechecking to create-gasket-app Oct 22, 2024
@jpina1-godaddy jpina1-godaddy marked this pull request as ready for review October 22, 2024 22:30
@jpina1-godaddy jpina1-godaddy requested a review from a team as a code owner October 22, 2024 22:30
Copy link
Contributor

@agerard-godaddy agerard-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small question/tweak - otherwise 👍

Copy link
Contributor

@kbader-godaddy kbader-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Woot!

@jpina1-godaddy jpina1-godaddy merged commit e4b1eb4 into main Oct 24, 2024
2 checks passed
@jpina1-godaddy jpina1-godaddy deleted the pfx-772 branch October 24, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants