Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PFX-768] Occasional CI failure #953

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[PFX-768] Occasional CI failure #953

merged 1 commit into from
Oct 24, 2024

Conversation

jpina1-godaddy
Copy link
Contributor

@jpina1-godaddy jpina1-godaddy commented Oct 23, 2024

Summary

The updated test in this PR was failing due to some test runs using windows \ paths. The test in this PR was updated to programmatically test the path instead of testing a hard coded path.

Changelog

@godaddy/create-gasket-app

  • Update flaky test

Test Plan

@jpina1-godaddy jpina1-godaddy changed the title tests: update flaky test [PFX-768] Occasional CI failure Oct 23, 2024
@jpina1-godaddy jpina1-godaddy marked this pull request as ready for review October 23, 2024 22:05
@jpina1-godaddy jpina1-godaddy requested a review from a team as a code owner October 23, 2024 22:05
Copy link
Contributor

@agerard-godaddy agerard-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@agerard-godaddy agerard-godaddy merged commit dc68e42 into main Oct 24, 2024
2 checks passed
@agerard-godaddy agerard-godaddy deleted the pfx-768-fix-test branch October 24, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants