Change gdscript-eglot-version type to be string instead of integer #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizable variable
gdscript-eglot-version
is used to locate editor settings file and extract LSP port from it when connecting via Eglot. Currently, this variable is of type integer.In godotengine/godot#90875, naming logic for the editor settings file was changed, and if you have, for example, Godot 4.3 installed, the corresponding editor settings file will be named
editor_settings-4.3.tres
. Becausegdscript-eglot-version
has an integer type and is formatted as such, it is impossible to specify the correct version of the Godot installation in that case.I changed the type of
gdscript-eglot-version
to a string to be able to specify any possible version format. Also, I've bumped the value ofgdscript-eglot-version
to the last stable version of Godot. As stated in #154, we can improve LSP port determination further by avoiding hard-coding this value, but this is good enough for now.