Improve Operating System Testing demo #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Display more return values of Engine/OS methods such as system fonts, memory information and security information. - Add headless support (the generated report is also printed to stdout). - Improve theming in the generated report. - Hide video adapter type if this information can't be queried in the current rendering method. - Update C# script for Godot 4.x platform names.
Calinou
force-pushed
the
improve-os-test
branch
from
c2a5cb4 to
2661ed8
Compare
aaronfranke
approved these changes
Oct 22, 2024
Calinou
commented
Oct 22, 2024
Comment on lines
+46
to
+48
| if DisplayServer.get_name() == "headless": | ||
| # Workaround for <https://github.com/godotengine/godot/issues/52821>. | ||
| return "" |
There was a problem hiding this comment.
Note that checking the audio driver name would be preferable, as you can use the Dummy audio driver but keep a non-headless display driver.
However, there's no reliable method to check for this that is exposed to scripting (see godotengine/godot#98435).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS.open_midi_inputscrashes with dummy audio godot#52821.Tested on 4.3.stable.
Preview
Stitched report
Full report stitched from multiple screenshots, so you can see it in all it sglory.
Headless support
From VS Code's integrated terminal: