From b92b3911f76e780c980bf727512455f4071adac1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= <rverschelde@gmail.com>
Date: Thu, 10 Aug 2023 14:04:09 +0200
Subject: [PATCH] SCons: Disable misbehaving MSVC incremental linking

Fixes #77968.

(cherry picked from commit bc1aef88eef7bb09d1c537bf150414c50abfa374)
---
 platform/windows/detect.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/platform/windows/detect.py b/platform/windows/detect.py
index 1bc3c89c9cc7..3a454e9a0903 100644
--- a/platform/windows/detect.py
+++ b/platform/windows/detect.py
@@ -214,6 +214,9 @@ def configure_msvc(env, manual_msvc_config):
     else:
         env.AppendUnique(CCFLAGS=["/MD"])
 
+    # MSVC incremental linking is broken and _increases_ link time (GH-77968).
+    env.Append(LINKFLAGS=["/INCREMENTAL:NO"])
+
     env.AppendUnique(CCFLAGS=["/Gd", "/GR", "/nologo"])
     env.AppendUnique(CCFLAGS=["/utf-8"])  # Force to use Unicode encoding.
     env.AppendUnique(CXXFLAGS=["/TP"])  # assume all sources are C++