Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree highlight selected items on hover #100412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

havi05
Copy link
Contributor

@havi05 havi05 commented Dec 14, 2024

Hovered items of a Tree are now highlighted, even if they are already selected.
Equivalent to this pr #99361, but for the Tree node.
Relates to godotengine/godot-proposals#7404

@havi05 havi05 requested review from a team as code owners December 14, 2024 20:08
@KoBeWi KoBeWi added this to the 4.x milestone Dec 14, 2024
@havi05 havi05 force-pushed the tree-hover-on-selected branch from 1284b0e to 0051935 Compare December 14, 2024 20:24
scene/gui/tree.cpp Outdated Show resolved Hide resolved
@havi05 havi05 force-pushed the tree-hover-on-selected branch from 0051935 to aff67b9 Compare January 4, 2025 10:24
@havi05 havi05 requested a review from KoBeWi January 6, 2025 20:56
@KoBeWi KoBeWi modified the milestones: 4.x, 4.5 Jan 20, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. I made sure no unnecessary redrawing occurs.

tree_hover_editor.mp4
tree_hover_project.mp4

However, when using a light editor theme, hover text becomes white when it should remain black:

tree_hover_editor_light.mp4

@havi05 havi05 force-pushed the tree-hover-on-selected branch from aff67b9 to 03caf44 Compare January 24, 2025 07:06
@havi05
Copy link
Contributor Author

havi05 commented Jan 24, 2025

Is fixed in editor_theme_manager.cpp line 960.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants