Use "literal" term where appropriate in shader language internals and in error messages. #101974
+187
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using "constant" to describe all instances of immutable declarations, whether that was an inline literal or an actual declared constant variable. This lack of disambiguation also resulted in some misleading error messages, ie: "expected integer constant" where only a literal is actually valid (and passing an actual constant like PI would fail with that exact error message). This also improves a few error messages that only stated the expectation of an integer literal when it was more appropriate to say an integer OR float literal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using "constant" to describe all instances of immutable declarations, whether that was an inline literal or an actual declared constant variable. This lack of disambiguation also resulted in some misleading error messages, ie: "expected integer constant" where only a literal is actually valid (and passing an actual constant like PI would fail with that exact error message).
This also improves a few error messages that only stated the expectation of an integer constant when it was more appropriate to say an integer OR float literal. This was originally brought up here: #101926
If this gets a green light I'll also take a stab at shoring up the docs to see if there's improvements to be made around "constant" vs "literal".
Before:
After:
