Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DisplayServer] Decouple show_window(MAIN_WINDOW_ID) from DisplayServer constructor, update project manager size/position after DS init. #101980

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[DisplayServer] Decouple show_window(MAIN_WINDOW_ID) from DisplayServer constructor, update project manager size/position after DS init. #101980

wants to merge 1 commit into from
+68 −23

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 24, 2025

Should fix project manager window jumping and changing size during start.

  • Decouples show_window(MAIN_WINDOW_ID) from DisplayServer constructor.
  • Applies EDSCALE to project manager window between DisplayServer init/main window creation (since functional DisplayServer to determine scale) and show_window(MAIN_WINDOW_ID).
  • Reverts Fix project manager window size when EDSCALE is not 1.0. #101576 changes (no longer needed).

Tested on:

  • macOS
  • Windows
  • Linux/X11
  • Linux/Wayland (won't work since currently there's no show_window implemented at all)

@bruvzg bruvzg added this to the 4.x milestone Jan 24, 2025
@bruvzg
[DisplayServer] Decouple show_window(MAIN_WINDOW_ID) from `DisplayS…
448ff43 
…erver` constructor, update project manager size/position after DS init.
Calinou
Calinou approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Windows 11 24H2 (150% editor scale), it works as expected for both the project manager and editor window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement platform:linuxbsd platform:macos platform:windows topic:gui topic:porting
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @Calinou